Bug #1692: Command-T prompt redraw issues on MacVim

Comments

1. anonymous 2010-10-05T13:10:32Z

   It happens in terminal also, tested in iTerm and Terminal.app, MacVim 7.3

2. Greg Hurrell 2010-10-05T13:21:37Z

   Funny, I haven't been able to reproduce it in the Terminal. Can you provide a recipe for reproducing it there?

3. anonymous 2010-10-05T14:29:42Z

   just MacVim running in terminal, nothing special compiled Vim from source, run in terminal - works as it must, so it's pure MacVim issue

4. Greg Hurrell 2010-10-05T14:33:27Z

   No, I mean what sequence to you follow to trigger the problem? (ie. keypresses)

   I've tried in the Terminal and I can't get it to trigger (admittedly I was just randomly opening and closing things with Command-T).

5. phoenix 2010-10-05T15:07:31Z

   sequence was \tnavig|a|t|or| where "|" is a moment when prompt dis- and re-appeared. But there is no pattern, it behaves differently on another sequences (but the same way on the same sequence)

6. Israel 2010-10-16T23:17:03Z

   I can reproduce the problem in the terminal and the GUI, the text disappears whenever I type a character that changes the files list, characters that doesn't change the list maintain the text visible.

7. Greg Hurrell 2010-10-17T02:23:04Z

   Thanks for the tip, Israel. Good to have this narrowed down like that.

8. anonymous 2010-10-21T00:19:09Z

   I can confirm, is definitely an issue with redraw after resizing the buffer containing the results list - occurs every time the buffer line length changes.

9. Greg Hurrell 2010-11-03T15:29:09Z

   Closed ticket #1723 as a duplicate of this one.

10. Greg Hurrell 2010-11-03T16:22:33Z

    Testing with git bisect reveals that commit ba44868 introduced the bug:

    https://github.com/b4winckler/macvim/commit/ba4486860ecda4b5e3584c0938abcc5046f1beaa

    commit ba4486860ecda4b5e3584c0938abcc5046f1beaa (HEAD, refs/bisect/bad)
    Author: Bjorn Winckler <bjorn.winckler@gmail.com>
    Date:   Mon Jul 5 18:02:03 2010 +0200
    
        Fix display corruption when dragging divider
        
        This fixes a bug where the screen would get corrupted when dragging a
        horizontal divider in full-screen mode.
    
    diff --git a/src/window.c b/src/window.c
    index b5061cd..abd107b 100644
    --- a/src/window.c
    +++ b/src/window.c
    @@ -5559,7 +5559,12 @@ win_new_height(wp, height)
         wp->w_prev_fraction_row = wp->w_wrow;
     
         win_comp_scroll(wp);
    +#ifdef FEAT_GUI_MACVIM
    +    /* The view may have moved, so clear all or display may get corrupted. */
    +    redraw_win_later(wp, CLEAR);
    +#else
         redraw_win_later(wp, SOME_VALID);
    +#endif
     [/tags/ifdef #ifdef] FEAT_WINDOWS
         wp->w_redr_status = TRUE;
     [/tags/endif #endif]

11. Greg Hurrell 2010-11-03T16:41:18Z

    I've just posted to the vim_mac group asking about this and suggesting a possible fix:

    • http://groups.google.com/group/vim_mac/browse_thread/thread/a6c2e541a1382a8d

12. Greg Hurrell 2010-11-04T17:31:13Z

    Judging from that thread it looks like Björn will apply the fix and it will probably stay in unless people find that it breaks things for them.

    So I'm going to mark this ticket as closed for now.

13. Greg Hurrell 2010-11-04T17:31:32Z

    Status changed:

    • From: new
    • To: closed

14. Greg Hurrell 2010-12-21T16:56:43Z

    The just-released MacVim snapshot 56 includes a fix for this issue. See the Google groups thread for more information.

Add a comment

Comments are now closed for this issue.